Skip to content

Fix false browser initialization diagnostics - #747

Merged
roncohen merged 2 commits into
mainfrom
fix/flag-state-initialization-diagnostic
Sep 25, 2026
Merged

roncohen merged 2 commits into
mainfrom
fix/flag-state-initialization-diagnostic

Conversation

@roncohen

Copy link
Copy Markdown
Contributor

Summary

  • track whether evaluated flag state is available in FlagsClient
  • mark state available before notifying flagsUpdated subscribers
  • avoid attaching CLIENT_NOT_INITIALIZED to valid evaluations delivered while client initialization is completing
  • add regression coverage for the initialization event ordering

Verification

  • cd packages/browser-sdk && ./node_modules/.bin/vitest run test/usage.test.ts
  • cd packages/browser-sdk && ../../node_modules/.bin/tsc --project tsconfig.build.json --noEmit
  • oxlint and oxfmt on changed files

Review

  • completed a simplification/refactor pass
  • completed a final diff review; no actionable findings

Copilot AI lite review requested due to automatic review settings September 24, 2026 19:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@roncohen
roncohen added this pull request to the merge queue Sep 25, 2026
Copilot AI review requested due to automatic review settings September 25, 2026 09:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Merged via the queue into main with commit 0840683 Sep 25, 2026
5 of 6 checks passed
@roncohen
roncohen deleted the fix/flag-state-initialization-diagnostic branch September 25, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants